New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95841: IDLE - Revise Windows local doc url #95845
Conversation
python#91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the Windows-only import, but maybe you know that's fine.
Thank you for reviewing. After fixes, manual re-tests on repository 3.12 and installed 3.11 still pass. A found hours ago, I found an August 2012 patch by Ned Deily updating the linux and macOS locations and changing the code a bit. I am saving that, with new updates, for 3.11.1. |
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
pythonGH-91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile. Co-authored-by: Steve Dower (cherry picked from commit bdb2cf8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-95905 is a backport of this pull request to the 3.11 branch. |
pythonGH-91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile. Co-authored-by: Steve Dower (cherry picked from commit bdb2cf8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-95906 is a backport of this pull request to the 3.10 branch. |
GH-91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Steve Dower Approved by Steve Dower, #95845 (review), 2nd subblock. (cherry picked from commit bdb2cf8)
#91242 replaced the Windows chm help file with a copy
of the html docs. This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
It is based on Steve Dower's #91242 (comment).
Co-authored-by: Steve Dower