Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95707: Fix function signature #95995

Merged
merged 1 commit into from Aug 15, 2022
Merged

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 15, 2022

@markshannon
Copy link
Member

Thanks for fixing this.

It's nice to have runtime type checking, but the error message is not very informative.

RuntimeError: null function or function signature mismatch

Is it null or not? What function?
Would it be possible to improve the error message, so those of us less familiar with web assembly can fix them?

@markshannon
Copy link
Member

@tiran Want to run the buildbots on this?
I'm happy to merge it, otherwise.

@markshannon
Copy link
Member

I'll take that as a "merge" then 🙂

@markshannon markshannon merged commit 8621e6d into python:main Aug 15, 2022
@tiran
Copy link
Member Author

tiran commented Aug 15, 2022

No need to run buildbots. I verified the patch locally.

It is a bit unfortunate that WASM runtimes and Emscripten do not provide more debug information. The error message is coming from NodeJS, probably from the V8 JavaScript engine itself. There is an outstanding feature request to improve the situation, emscripten-core/emscripten#16126 . -Wbad-function-cast -Wcast-function-type detects some mismatches, but it would not detect this mismatch.

@hoodmane has been looking into the problem, too.

@tiran tiran deleted the gh-95707-fix branch August 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants