bpo-29001 Update handlers.py to address abnormal behavior when using RotatingFileHandler under gunicorn multiple workers #9616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RotatingFileHandler,
For gunicorn running with multiple workers, each worker will have separate RotatingFileHandler instances. Due to this, when rollover occurs, the effect is reflected only for the current worker. Due to this, while rotation, multiple new .log file is being created and the new logs keep emitting in these new files (Unexpected!). The situation is illustrated here too.
https://bugs.python.org/issue29001
Hence, as a solution, to propagate the rollover for all workers, both stream_size and file_size has to be checked and take action accordingly.
https://bugs.python.org/issue29001