Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95432: Add doctest for sqlite3 tutorial #96193

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 22, 2022

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems LGTM, aside from one concern, though to be honest my knowledge of doctests is mostly limited to skimming the Sphinx docs on them

Doc/library/sqlite3.rst Show resolved Hide resolved
@erlend-aasland erlend-aasland merged commit 04c73e5 into python:main Aug 23, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, CAM!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland deleted the sqlite-doctest branch August 23, 2022 06:48
@bedevere-bot
Copy link

GH-96200 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 23, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-96201 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2022
miss-islington added a commit that referenced this pull request Aug 23, 2022
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Aug 23, 2022
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@erlend-aasland erlend-aasland linked an issue Aug 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all sqlite3 doc examples work
4 participants