Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90467: StreamReaderProtocol - add strong reference to created task #96323

Merged
merged 4 commits into from
Aug 27, 2022
Merged

gh-90467: StreamReaderProtocol - add strong reference to created task #96323

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91c8678
gh-90467: StreamReaderProtocol - add strong reference to created task
python273 Aug 26, 2022
5289afe
Merge branch 'main' into fix-stream-reader-protocol-task-strong-refer…
gvanrossum Aug 26, 2022
ec8fb92
Merge branch 'main' into fix-stream-reader-protocol-task-strong-refer…
gvanrossum Aug 27, 2022
83a816d
Add blurb and ACKS
python273 Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/asyncio/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ def __init__(self, stream_reader, client_connected_cb=None, loop=None):
self._strong_reader = stream_reader
self._reject_connection = False
self._stream_writer = None
self._task = None
self._transport = None
self._client_connected_cb = client_connected_cb
self._over_ssl = False
Expand Down Expand Up @@ -247,7 +248,7 @@ def connection_made(self, transport):
res = self._client_connected_cb(reader,
self._stream_writer)
if coroutines.iscoroutine(res):
self._loop.create_task(res)
self._task = self._loop.create_task(res)
self._strong_reader = None

def connection_lost(self, exc):
Expand All @@ -265,6 +266,7 @@ def connection_lost(self, exc):
super().connection_lost(exc)
self._stream_reader_wr = None
self._stream_writer = None
self._task = None
self._transport = None

def data_received(self, data):
Expand Down