Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96359: Fix docs that claimed that int(0|1) doesn't match False #96361

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

L3viathan
Copy link
Contributor

@L3viathan L3viathan commented Aug 28, 2022

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 28, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Aug 28, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@brandtbucher
Copy link
Member

Yep, nice catch.

I wonder, would it make sense to call out False as being matched, rather than just removing it? It might be a bit out of place here, but could be useful to point out.

@L3viathan
Copy link
Contributor Author

I wonder, would it make sense to call out False as being matched, rather than just removing it?

Personally, I find it clear as-is, but I can also add another sentence, if you'd prefer. Not sure on the phrasing though.


Does the tag needs-backport-to-3.11 mean that I should open a duplicate PR targeting the 3.11 branch? (This is my first time submitting a PR to cpython, so I'm not familiar with the process. Unless someone tells me otherwise, I assume I don't have to do anything more.)

@brandtbucher
Copy link
Member

Does the tag needs-backport-to-3.11 mean that I should open a duplicate PR targeting the 3.11 branch?

Nope, the backports are all automated. The label is for the bots. :)

(This is my first time submitting a PR to cpython, so I'm not familiar with the process. Unless someone tells me otherwise, I assume I don't have to do anything more.)

You're all done here. Thanks, and welcome to CPython!

@brandtbucher brandtbucher added the needs backport to 3.10 only security fixes label Aug 28, 2022
@brandtbucher brandtbucher merged commit 3d3a86e into python:main Aug 28, 2022
@miss-islington
Copy link
Contributor

Thanks @L3viathan for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2022
…honGH-96361)

(cherry picked from commit 3d3a86e)

Co-authored-by: Jonathan Oberländer <github@l3vi.de>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 28, 2022
@bedevere-bot
Copy link

GH-96367 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2022
…honGH-96361)

(cherry picked from commit 3d3a86e)

Co-authored-by: Jonathan Oberländer <github@l3vi.de>
@bedevere-bot
Copy link

GH-96368 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 28, 2022
miss-islington added a commit that referenced this pull request Aug 29, 2022
(cherry picked from commit 3d3a86e)

Co-authored-by: Jonathan Oberländer <github@l3vi.de>
miss-islington added a commit that referenced this pull request Aug 29, 2022
(cherry picked from commit 3d3a86e)

Co-authored-by: Jonathan Oberländer <github@l3vi.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants