Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988) #97574

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 26, 2022

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner vstinner@python.org

)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a failure or timed out ❌.

@ambv
Copy link
Contributor

ambv commented Oct 4, 2022

Test failing on Windows, looks legitimate: AssertionError: 0.015625 not less than 0.013671875. I'll re-run just in case.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ambv
Copy link
Contributor

ambv commented Oct 4, 2022

...and it passed 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants