Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98832: Change wording in docstring of pathlib.Path.iterdir #98833

Merged
merged 5 commits into from
Nov 9, 2022
Merged

gh-98832: Change wording in docstring of pathlib.Path.iterdir #98833

merged 5 commits into from
Nov 9, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 28, 2022 •
edited by miss-islington
Loading

Found while working on #98829

Automerge-Triggered-By: GH:AlexWaygood

hauntsaninja
hauntsaninja reviewed Oct 29, 2022
View reviewed changes
Lib/pathlib.py Outdated Show resolved Hide resolved
@sobolevn @hauntsaninja
Update Lib/pathlib.py
efef10e 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
AlexWaygood
AlexWaygood reviewed Oct 29, 2022
View reviewed changes
Lib/pathlib.py Outdated Show resolved Hide resolved
@sobolevn @AlexWaygood
Update Lib/pathlib.py
4af4f3f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I won't merge just yet, in case Brett has some feedback)

@iritkatriel iritkatriel changed the title gh-98832: Change wording in pathlib.Path.iterdir gh-98832: Change wording in docstring of pathlib.Path.iterdir Nov 5, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 5, 2022
Closed
brettcannon
brettcannon requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stdlib practice is a single sentence summarizing what something does, a newline, and then any relevant details. We should probably go ahead and fix that now.

Otherwise LGTM!

Lib/pathlib.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevn @brettcannon
Update Lib/pathlib.py
428361a 
Co-authored-by: Brett Cannon <brett@python.org>
@sobolevn
Copy link
Member Author

sobolevn commented Nov 9, 2022

Thanks! Applied.

To make our bot happy:

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon, @AlexWaygood: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 5 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 87f5180 into python:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sobolevn @bedevere-bot @miss-islington @brettcannon @hauntsaninja @AlexWaygood