gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

pablogsal · 2022-11-30T11:22:58Z

Issue: test_traceback: test_import_from_error_bad_suggestions_do_not_trigger_for_small_names() fails randomly on "wasm32-emscripten node (dynamic linking)" buildbot #99894

…le in traceback suggestion error checking

vstinner · 2022-11-30T11:38:58Z

This branch doesn't work for me:

vstinner@mona$ ./python -m test test_traceback -j20 -F -m test_import_from_error_bad_suggestions_do_not_trigger_for_small_names -v
(...)
0:00:07 load avg: 8.01 [ 36/1] test_traceback failed (1 failure)
test_import_from_error_bad_suggestions_do_not_trigger_for_small_names (test.test_traceback.CPythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names) ... 
  test_import_from_error_bad_suggestions_do_not_trigger_for_small_names (test.test_traceback.CPythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names) (name='py') ... FAIL
test_import_from_error_bad_suggestions_do_not_trigger_for_small_names (test.test_traceback.PurePythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names) ... ok

======================================================================
FAIL: test_import_from_error_bad_suggestions_do_not_trigger_for_small_names (test.test_traceback.CPythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names) (name='py')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vstinner/python/main/Lib/test/test_traceback.py", line 3172, in test_import_from_error_bad_suggestions_do_not_trigger_for_small_names
    self.assertNotIn("vvv", actual)
AssertionError: 'vvv' unexpectedly found in "ImportError: cannot import name 'py' from 'NkosMVLvvvpdqPze' (/tmp/test_python_xfxl02nj/tmp7l231ock/NkosMVLvvvpdqPze.py)"

$ git show
commit 5612e561a96f4da735e966f527e1e01265564ae1 (HEAD -> pr/99895)
Author: Pablo Galindo <pablogsal@gmail.com>
Date:   Wed Nov 30 11:22:49 2022 +0000

    gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking

vstinner · 2022-11-30T11:41:06Z

Ah, this PR changes test_getattr_error_bad_suggestions_do_not_trigger_for_small_names(), but not test_import_from_error_bad_suggestions_do_not_trigger_for_small_names().

You should also change test_import_from_error_bad_suggestions_do_not_trigger_for_small_names(), no?

…test file in traceback suggestion error checking

pablogsal · 2022-11-30T11:42:05Z

Ah, this PR changes test_getattr_error_bad_suggestions_do_not_trigger_for_small_names(), but not test_import_from_error_bad_suggestions_do_not_trigger_for_small_names().

You should also change test_import_from_error_bad_suggestions_do_not_trigger_for_small_names(), no?

Done!

vstinner · 2022-11-30T12:02:58Z

I ran ./python -m test test_traceback -j20 -F -m test_import_from_error_bad_suggestions_do_not_trigger_for_small_names -v for 9 min 24 sec: 3669 tests OK.

vstinner · 2022-11-30T12:04:29Z

Another test: ./python -m test test_traceback -j20 -F -v ran for 4 min 50 sec: 52 tests OK.

vstinner · 2022-11-30T12:14:12Z

Another test: ./python -m test test_traceback -j20 -F -m test_getattr_error_bad_suggestions_do_not_trigger_for_small_names -v ran for 9 min 28 sec: 5086 tests OK.

vstinner

LGTM: I tested functionnaly the change, it does fix #99894

I have a minor suggestion.

vstinner · 2022-11-30T12:16:29Z

Lib/test/test_traceback.py

@@ -2979,8 +2979,8 @@ class MyClass:
            with self.subTest(name=name):
                actual = self.get_suggestion(MyClass, name)
                self.assertNotIn("you mean", actual)


Maybe check for Did you mean? Same remark for the other test.

Other test_traceback tests check for this (a little bit longer) pattern.

Lib/test/test_traceback.py

vstinner · 2022-12-01T11:26:50Z

test_threading of "Address sanitizer" failed (env changed). I re-ran this CI job.

vstinner · 2022-12-01T13:07:18Z

Python 3.10 and 3.11 are not affected.

bedevere-bot · 2022-12-01T14:55:26Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 0563be2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/3060) and take a look at the build logs.
Check if the failure is related to this commit (0563be2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/3060

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

test_venv: 12 min 28 sec
test_largefile: 8 min 51 sec
test_lib2to3: 6 min 28 sec
test_multiprocessing_spawn: 4 min 2 sec
test_concurrent_futures: 3 min 19 sec
test_asyncio: 3 min
test_tokenize: 2 min 5 sec
test_multiprocessing_forkserver: 1 min 56 sec
test_gdb: 1 min 42 sec
test_cppext: 1 min 39 sec

1 test altered the execution environment:
test_concurrent_futures

21 tests skipped:
test_check_c_globals test_devpoll test_idle test_ioctl test_kqueue
test_launcher test_msilib test_peg_generator test_perf_profiler
test_startfile test_tcl test_tix test_tkinter test_ttk
test_ttk_textonly test_turtle test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

Total duration: 29 min 44 sec

Click to see traceback logs

remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 5 (delta 4), reused 0 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '0563be23a557917228a8b48cbb31bda285a3a815'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 0563be23a5 gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (#99895)
Switched to and reset branch 'main'

Objects/obmalloc.c:776:1: warning: ‘always_inline’ function might not be inlinable [-Wattributes]
  776 | arena_map_get(pymem_block *p, int create)
      | ^~~~~~~~~~~~~

make: *** [Makefile:1889: buildbottest] Error 3

* main: (112 commits) pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895) pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613) Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917) pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916) pythongh-89189: More compact range iterator (pythonGH-27986) bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491) pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906) pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850) pythongh-99845: Use size_t type in __sizeof__() methods (python#99846) pythonGH-99877) Fix typo in exception message in `multiprocessing.pool` (python#99900) pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869) pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893) pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825) pythonGH-81057: remove static state from suggestions.c (python#99411) Improve zip64 limit error message (python#95892) pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591) pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128) pythongh-82836: fix private network check (python#97733) Docs: improve accuracy of socketserver reference (python#24767) ...

kadiwa4 · 2022-12-02T11:38:45Z

Lib/test/test_traceback.py

-                self.assertNotIn("vvv", actual)
-                self.assertNotIn("mom", actual)
+                self.assertNotIn("Did you mean", actual)
+                self.assertNotIn("'vvv", actual)


I don't know if this has any effect but there is a ' missing here

… test file in traceback suggestion error checking (python#99895)" This reverts commit 0563be2.

pythongh-99894: Ensure the local names don't collide with the test fi…

5612e56

…le in traceback suggestion error checking

pablogsal requested a review from iritkatriel as a code owner November 30, 2022 11:22

bedevere-bot mentioned this pull request Nov 30, 2022

test_traceback: test_import_from_error_bad_suggestions_do_not_trigger_for_small_names() fails randomly on "wasm32-emscripten node (dynamic linking)" buildbot #99894

Closed

bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Nov 30, 2022

pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 30, 2022

fixup! pythongh-99894: Ensure the local names don't collide with the …

d159ac5

…test file in traceback suggestion error checking

vstinner approved these changes Nov 30, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Nov 30, 2022

kumaraditya303 added the skip news label Nov 30, 2022

vstinner reviewed Nov 30, 2022

View reviewed changes

Lib/test/test_traceback.py Outdated Show resolved Hide resolved

Lib/test/test_traceback.py Outdated Show resolved Hide resolved

vstinner added 2 commits November 30, 2022 16:54

Update Lib/test/test_traceback.py

2287142

Update Lib/test/test_traceback.py

227b315

vstinner merged commit 0563be2 into python:main Dec 1, 2022

bedevere-bot removed the awaiting merge label Dec 1, 2022

kadiwa4 reviewed Dec 2, 2022

View reviewed changes

sobolevn mentioned this pull request Dec 4, 2022

test_capi fails with "Maximum call stack size exceeded" on "wasm32-emscripten node (pthreads) 3.x" buildbot #99985

Closed

sobolevn added a commit to sobolevn/cpython that referenced this pull request Dec 28, 2022

Revert "pythongh-99894: Ensure the local names don't collide with the…

ce557be

… test file in traceback suggestion error checking (python#99895)" This reverts commit 0563be2.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

pablogsal commented Nov 30, 2022 •

edited by bedevere-bot

vstinner commented Nov 30, 2022

vstinner commented Nov 30, 2022

pablogsal commented Nov 30, 2022

vstinner commented Nov 30, 2022

vstinner commented Nov 30, 2022

vstinner commented Nov 30, 2022

vstinner left a comment

vstinner Nov 30, 2022

vstinner commented Dec 1, 2022

vstinner commented Dec 1, 2022

bedevere-bot commented Dec 1, 2022

kadiwa4 Dec 2, 2022

gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

Conversation

pablogsal commented Nov 30, 2022 • edited by bedevere-bot

vstinner commented Nov 30, 2022

vstinner commented Nov 30, 2022

pablogsal commented Nov 30, 2022

vstinner commented Nov 30, 2022

vstinner commented Nov 30, 2022

vstinner commented Nov 30, 2022

vstinner left a comment

Choose a reason for hiding this comment

vstinner Nov 30, 2022

Choose a reason for hiding this comment

vstinner commented Dec 1, 2022

vstinner commented Dec 1, 2022

bedevere-bot commented Dec 1, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

kadiwa4 Dec 2, 2022

Choose a reason for hiding this comment

pablogsal commented Nov 30, 2022 •

edited by bedevere-bot