Turn warnings into errors in the Makefile. (#906)

* Turn warnings into errors in the Makefile.

* Restore missing label.

* Add `--keep-going`.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

* Add `-W --keep-going -n` to SPHINXOPTS.

* Fix a warning in conf.py.

* Update `make.bat`.

* Unquote variable in make.bat.

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

Makefile

@@ -5,7 +5,7 @@
 PYTHON        = python3
 VENVDIR       = ./venv
 BUILDDIR      = _build
-SPHINXOPTS    =
+SPHINXOPTS    = -W --keep-going -n
 SPHINXBUILD   = $(VENVDIR)/bin/sphinx-build
 SPHINXLINT    = $(VENVDIR)/bin/sphinx-lint
 PAPER         =

conf.py

@@ -40,7 +40,7 @@
 # http://www.sphinx-doc.org/en/stable/config.html?highlight=linkcheck#confval-linkcheck_anchors_ignore
 linkcheck_anchors_ignore = [
     # match any anchor that starts with a '/' since this is an invalid HTML anchor
-    '\/.*',
+    r'\/.*',
 ]
 rediraffe_redirects = {
     "clang.rst": "advanced-tools/clang.rst",

make.bat

@@ -22,6 +22,7 @@ if not defined SPHINXLINT (
 )
 
 set BUILDDIR=_build
+set SPHINXOPTS=-W --keep-going -n
 set ALLSPHINXOPTS=-d %BUILDDIR%/doctrees %SPHINXOPTS% .
 if NOT "%PAPER%" == "" (
 	set ALLSPHINXOPTS=-D latex_paper_size=%PAPER% %ALLSPHINXOPTS%