Skip to content

Commit

Permalink
Add green and red side border for good and bad examples (#1237)
Browse files Browse the repository at this point in the history
  • Loading branch information
hugovk committed Dec 7, 2023
1 parent 44e62d5 commit 53452a7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
7 changes: 7 additions & 0 deletions _static/devguide_overrides.css
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,10 @@
fill: #2222EE;
stroke: #008888;
}

.good pre {
border-left: 3px solid rgba(74, 182, 93, 1);
}
.bad pre {
border-left: 3px solid rgb(244, 76, 78);
}
4 changes: 4 additions & 0 deletions getting-started/git-boot-camp.rst
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ In either case, adjust and clean up the commit message.
✅ Here's an example of a **good** commit message:

.. code-block:: text
:class: good
gh-12345: Improve the spam module (GH-777)
Expand All @@ -501,6 +502,7 @@ In either case, adjust and clean up the commit message.
❌ Here's an example of a **bad** commit message:

.. code-block:: text
:class: bad
gh-12345: Improve the spam module (#777)
Expand Down Expand Up @@ -576,6 +578,7 @@ one as is and delete the number of the backport pull request.
✅ Example of good backport commit message:

.. code-block:: text
:class: good
gh-12345: Improve the spam module (GH-777)
Expand All @@ -587,6 +590,7 @@ one as is and delete the number of the backport pull request.
❌ Example of bad backport commit message:

.. code-block:: text
:class: bad
gh-12345: Improve the spam module (GH-777) (#888)
Expand Down

0 comments on commit 53452a7

Please sign in to comment.