Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should an issue be created first, before the Pull Request? #104

Closed
Mariatta opened this issue Feb 11, 2017 · 3 comments
Closed

Should an issue be created first, before the Pull Request? #104

Mariatta opened this issue Feb 11, 2017 · 3 comments
Labels

Comments

@Mariatta
Copy link
Member

In the Quick Start section of the Dev Guide:

5. Make a pull request.

6. Create an issue on the issue tracker if one does not already exist.

Just wondering if it might be better if an issue be created first (in bpo) before the pull request?
This way Pull Request can be created with bpo-NNNN: in the PR title as well as the commit message.

@ezio-melotti
Copy link
Member

Maybe we could even leave this out from the quick start, in most of the cases there is already an issue, or one is created beforehand in order to discuss the details of the fix. Eventually we might also automate the issue creation for PR that don't refer to any existing issue.

@matrixise
Copy link
Member

Or just add "If there is no issue, create it before the PR and note the PR with "bpo-ISSUENUMBER Description".

@berkerpeksag
Copy link
Member

We should also mention that there is no need create an issue for trivial changes like typo fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants