Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

omitting the "unused" prompt in code example #1210

Merged
merged 2 commits into from
Nov 3, 2023
Merged

omitting the "unused" prompt in code example #1210

merged 2 commits into from
Nov 3, 2023

Conversation

shashankshet
Copy link
Contributor

@shashankshet shashankshet commented Oct 31, 2023

Omitting the "unused" prompt in code example

updated the doc by removing unused prompt


馃摎 Documentation preview 馃摎: https://cpython-devguide--1210.org.readthedocs.build/

Copy link

cpython-cla-bot bot commented Oct 31, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@shashankshet
Copy link
Contributor Author

Update line 614-615 as per review comment, please review

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shashankshet for the PR and making your first contribution to the dev guide. 馃悕 馃悕 馃帀

@terryjreedy
Copy link
Member

@willingc Are you planning to merge this?

@willingc
Copy link
Collaborator

willingc commented Nov 3, 2023

@terryjreedy Will do! Thanks for reviewing again.

@willingc willingc merged commit 4961fe7 into python:main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants