Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes are discouraged #1290

Merged
merged 1 commit into from Mar 20, 2024
Merged

Footnotes are discouraged #1290

merged 1 commit into from Mar 20, 2024

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Mar 19, 2024

This is a better way to explain more about literalinclude


馃摎 Documentation preview 馃摎: https://cpython-devguide--1290.org.readthedocs.build/

@nedbat nedbat requested a review from hugovk March 19, 2024 15:05
.. note::
There is a standard ``include`` directive, but it raises errors if the
file is not found. ``literalinclude`` is preferred because it only emits a
warning in that case.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedbat Can you clarify "in that case" please? Perhaps "...because it emits a warning instead of an error."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from footnote to regular note is ok, but why would a warning be preferred over an error?

@nedbat
Copy link
Member Author

nedbat commented Mar 19, 2024

I assumed it was because it doesn't stop the build, but I could be wrong.

@willingc willingc merged commit 1eae014 into python:main Mar 20, 2024
4 checks passed
@nedbat nedbat deleted the nedbat/no-footnotes branch March 20, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants