Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS instructions to the devguide #1296

Merged
merged 5 commits into from Mar 27, 2024
Merged

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Mar 21, 2024

Part of the PEP 730 work (python/cpython#114099).

Adds iOS details to the devguide.

Also adds a note about htmlview and htmllive to the README, as they're too helpful to go hidden :-)


📚 Documentation preview 📚: https://cpython-devguide--1296.org.readthedocs.build/getting-started/setup-building/

getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some little nits.

Also adds a note about htmlview and htmllive to the README, as they're too helpful to go hidden :-)

Good idea, they're great!

getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Mar 22, 2024

@ezio-melotti Did you want to re-review? If not, let's merge.

@freakboy3742
Copy link
Contributor Author

Checking in on this PR - is there anything else needed on my part?

@hugovk
Copy link
Member

hugovk commented Mar 27, 2024

Let's merge, thank you!

@hugovk hugovk merged commit 45f7b02 into python:main Mar 27, 2024
4 checks passed
@freakboy3742 freakboy3742 deleted the ios-devguide branch March 27, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants