Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and build instructions wrt. libmpdecimal #1313

Merged
merged 3 commits into from May 3, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 29, 2024

@erlend-aasland erlend-aasland changed the title macOS: Recommend building with system installed libmpdecimal Update deps and build instructions wrt. libmpdecimal Apr 29, 2024
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, once we change the configure default for --with-system-libmpdec there really wouldn't need to be a separate recipe for 3.13, as long as people didn't care which version of libmpdec is being used.

@erlend-aasland erlend-aasland merged commit 5c6a0c1 into python:main May 3, 2024
4 checks passed
@erlend-aasland erlend-aasland deleted the decimal branch May 3, 2024 06:33
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 3, 2024

Thanks for the review!

LGTM, although, once we change the configure default for --with-system-libmpdec there really wouldn't need to be a separate recipe for 3.13, [...]

Yep.

[...] as long as people didn't care which version of libmpdec is being used.

I don't think the devguide recipe is the place for that user group; for people who care about a particular version of a build dependency, we have https://docs.python.org/3/using/configure.html 1.

Footnotes

  1. ... and in this particular case, it is https://docs.python.org/3.13/using/configure.html#cmdoption-with-system-libmpdec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants