Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Temporarily ignore deprecation warnings from Sphinx #69

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix CI: Temporarily ignore deprecation warnings from Sphinx #69

merged 1 commit into from
Nov 14, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 11, 2022

Re: #68 (comment)

Sphinx is failing on the CI because we're turning warnings into errors (-W error) and Sphinx is using imghdr, and triggering a deprecation warning:

Run python -bb -X dev -W error -m sphinx --color -n -E -a -W --keep-going docs build
Running Sphinx v5.3.0

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/warnings.py", line 514, in _deprecated
    warn(msg, DeprecationWarning, stacklevel=3)
DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
The full traceback has been saved in /tmp/sphinx-err-tfj_[8](https://github.com/hugovk/docs-community/actions/runs/3445416680/jobs/5749102789#step:5:9)37y.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

Let's temporarily disable deprecation warnings until sphinx-doc/sphinx#10440 is fixed.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

@encukou
Copy link
Member

encukou commented Nov 14, 2022

Thanks for getting to this!

@encukou encukou merged commit ccc2d9b into python:main Nov 14, 2022
@hugovk hugovk deleted the fix-warning branch November 14, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants