Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically edit PRs with link to RTD preview #74

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Automatically edit PRs with link to RTD preview #74

merged 1 commit into from
Feb 28, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 28, 2023

Let's try this by RTD: https://github.com/readthedocs/actions/tree/v1/preview

GitHub Action that automatically edits Pull Requests' descriptions with a link to documentation's preview on Read the Docs.

For example:

image

@hugovk hugovk marked this pull request as draft February 28, 2023 13:16
@hugovk hugovk marked this pull request as ready for review February 28, 2023 13:28
@hugovk
Copy link
Member Author

hugovk commented Feb 28, 2023

I think this needs to be merged before it's active.

@humitos
Copy link
Contributor

humitos commented Feb 28, 2023

@hugovk yes, you have to merge the PR to be executed. I haven't find a way on GitHub to be able to test these actions from a Pull Request unfortunately.

@encukou encukou merged commit 536d641 into python:main Feb 28, 2023
@hugovk hugovk deleted the rtd-pr-preview branch February 28, 2023 14:49
@hugovk hugovk mentioned this pull request Feb 28, 2023
@CAM-Gerlach
Copy link
Member

yes, you have to merge the PR to be executed. I haven't find a way on GitHub to be able to test these actions from a Pull Request unfortunately.

Testing it on your fork works if it doesn't require something specific on the upstream, and I believe pushing it to a new upstream branch and then submitting a PR against that branch might work too, depending on the workflow trigger.

@hugovk
Copy link
Member Author

hugovk commented Mar 1, 2023

Thank you @humitos (and RTD) for the Action (and RTD)!

@humitos
Copy link
Contributor

humitos commented Mar 1, 2023

@CAM-Gerlach

Testing it on your fork works

That's a pretty simple and great idea! 💯 . I haven't thought about this before. I will start using this workflow from now on 👍🏼 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants