Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry failed backport. Just leave a message. #237

Merged
merged 4 commits into from May 29, 2019
Merged

Don't retry failed backport. Just leave a message. #237

merged 4 commits into from May 29, 2019

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented May 29, 2019

If celery or redis is down, then we can't perform "sleep".
Heroku's web dyno times out after 30 seconds. 馃槬

If celery or redis is down, then we can't perform "sleep".
Heroku's web dyno times out after 30 seconds. 馃槬
@black-out
Copy link

@black-out black-out bot commented May 29, 2019

馃悕馃寶馃 PR is already black! Good job!

@black-out black-out bot removed the black out label May 29, 2019
@codecov
Copy link

@codecov codecov bot commented May 29, 2019

Codecov Report

Merging #237 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage      96%   95.94%   -0.07%     
==========================================
  Files           9        9              
  Lines         827      813      -14     
  Branches       50       49       -1     
==========================================
- Hits          794      780      -14     
  Misses         33       33
Impacted Files Coverage 螖
tests/test_backport_pr.py 100% <100%> (酶) 猬嗭笍
miss_islington/backport_pr.py 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9a30fdf...ebcc01a. Read the comment docs.

@black-out
Copy link

@black-out black-out bot commented May 29, 2019

馃悕馃寶馃 PR is already black! Good job!

@black-out black-out bot removed the black out label May 29, 2019
@Mariatta Mariatta merged commit 87815b7 into master May 29, 2019
4 checks passed
@Mariatta Mariatta deleted the no-sleep branch May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants