TypeGuard does not narrow when statement compares for identity (is True)

[flaeppe]

Bug Report

In the example below f is a TypeGuard that mypy fails to narrow the type with when the statement compares with identity (is True)

To Reproduce

https://mypy-play.net/?mypy=master&python=3.12&flags=strict&gist=688d7597c968ed90ecdd8d4bf2b3a8a3

from typing import TypeGuard

def f(value: str) -> TypeGuard[int]:
    return True

# This should narrow to "builtins.int"
by_identity = "123"
assert f(by_identity) is True
reveal_type(by_identity)  # Revealed type is "builtins.str"

Expected Behavior

Revealed type is "builtins.int"

Actual Behavior

Revealed type is "builtins.str"

Your Environment

• Mypy version used: 1.10.1 (and master)
• Mypy command-line flags:
• Mypy configuration options from mypy.ini (and other config files):
• Python version used: 3.12

[sobolevn]

The same happens for

by_identity = "123"
assert f(by_identity) == True
reveal_type(by_identity)  # Revealed type is "builtins.str"

[sobolevn]

This happens because we only check for type guards here:

mypy/mypy/checker.py

Lines 5837 to 5839 in ec00fb8

	elif isinstance(node.callee, RefExpr):
	if node.callee.type_guard is not None or node.callee.type_is is not None:
	# TODO: Follow *args, **kwargs

But, is True / == True is checked in this branch:

mypy/mypy/checker.py

Line 5889 in ec00fb8

elif isinstance(node, ComparisonExpr):

It never really calls the first branch for its operands.

I think it would make sense to move the type guard part into a helper function and call it from both branches.

@flaeppe I can assign this on you if you want :)

[flaeppe]

@flaeppe I can assign this on you if you want :)

Sure, go ahead.

And thank you for the insight, I'll try to have a look