Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.720 planning #7137

Closed
ilevkivskyi opened this issue Jul 2, 2019 · 13 comments
Closed

Release 0.720 planning #7137

ilevkivskyi opened this issue Jul 2, 2019 · 13 comments
Assignees

Comments

@ilevkivskyi
Copy link
Member

I plan to release mypy 0.720 on Friday July 12. The release branch will be cut in one week, on Tuesday July 9.

This will be the first release where the new semantic analyzer will be used by default. The old one will be still available with --no-new-semantic-analyzer but will be likely removed in 0.730.

Please add comments to this issue if you have any PR you'd like to be included. Ideally those PRs should be landed before the release branch is cut, to minimize cherry-picking.

@Michael0x2a
Copy link
Collaborator

Oh wow, that was quick -- exciting!

There are a few enums and literal types related PRs I think would be nice to get merged -- namely:

But these PRs have been deferred for several releases, so I think it's no big deal if we defer them for another one.

This is also a heads-up that I'll be submitting a few more reachability related PRs later this week. One of those PRs will be adding docs for the --warn-unreachable flag: I'd like to get that one landed before the release. The other PRs will be less important, I think.

@brandtbucher
Copy link
Member

Typo in the issue title?

@ilevkivskyi
Copy link
Member Author

Typo in the issue title?

Oh indeed :-) Will fix now.

@ilevkivskyi ilevkivskyi changed the title Release 0.710 planning Release 0.720 planning Jul 2, 2019
@ilevkivskyi
Copy link
Member Author

There are a few enums and literal types related PRs I think would be nice to get merged -- namely:

Hm, interesting, I was thinking about exactly the same bunch of issues. I will try to land them by the end of the week.

@awelzel
Copy link
Contributor

awelzel commented Jul 3, 2019

@ilevkivskyi - mind checking out #7108? We're heavily using namespace packages and are running into #5854.

@ilevkivskyi
Copy link
Member Author

Someone else will need to review it, @gvanrossum will you have time for this?

@ilevkivskyi
Copy link
Member Author

I think #7044 is currently a release blocker.

@Deimos
Copy link
Contributor

Deimos commented Jul 9, 2019

@ilevkivskyi just to confirm (I created #7044) - my codebase no longer crashes with the new semantic analyzer after that fix, but it does output a number of errors that aren't actually errors. I haven't looked through them all yet, but they seem to mostly be related to either @property or SQLAlchemy @hybrid_property, including the issue I commented about here with a discrepancy in getter/setter types.

@ilevkivskyi
Copy link
Member Author

Release branch is cut: https://github.com/python/mypy/tree/release-0.720

@ilevkivskyi
Copy link
Member Author

@Deimos I believe most of those errors can be fixed by something like (didn't try this):

if TYPE_CHECKING:
    from builtins import property as hybrid_property
else:
    from sqlalchemy.ext.hybrid import hybrid_property

@Deimos
Copy link
Contributor

Deimos commented Jul 9, 2019

That seems to work, yes. That seems like a reasonable workaround to use, thanks!

@JelleZijlstra
Copy link
Member

In our codebase there seems to be a regression on current master where functions decorated with https://github.com/quora/qcore/blob/master/qcore/caching.pyi#L79 degenerate to Any. I'll have some time later today to investigate more and try to find a minimal repro.

@JelleZijlstra
Copy link
Member

I can't reproduce the problem I noted above now, so nothing further to do there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants