Improve pytest quality of life #10567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
commented
Jun 1, 2021
| strict_optional = saved | ||
| try: | ||
| yield | ||
| finally: |
There was a problem hiding this comment.
Prevents one failed tests from bleeding into another
ikonst
commented
Jun 1, 2021
| @@ -50,6 +50,7 @@ def assert_string_arrays_equal(expected: List[str], actual: List[str], | |||
|
|
|||
| Display any differences in a human-readable form. | |||
| """ | |||
| __tracebackhide__ = True | |||
There was a problem hiding this comment.
ikonst
commented
Jun 1, 2021
| @@ -326,18 +327,6 @@ def retry_on_error(func: Callable[[], Any], max_wait: float = 1.0) -> None: | |||
| raise | |||
| time.sleep(wait_time) | |||
|
|
|||
| # TODO: assert_true and assert_false are redundant - use plain assert | |||
There was a problem hiding this comment.
Follow up for PR #4369
JelleZijlstra
approved these changes
Jun 1, 2021
hauntsaninja
reviewed
Jun 1, 2021
mypy/test/testtypes.py
Outdated
| assert is_more_precise(fx.b, fx.b) | ||
| assert is_more_precise(fx.b, fx.b) | ||
| assert is_more_precise(fx.b, fx.anyt) | ||
| assert is_more_precise(self.tuple(fx.b, fx.a, |
There was a problem hiding this comment.
Looks like the find and replace wasn't quite right
hauntsaninja
reviewed
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finallyso that tests don't bleed into each other and cause unrelated tests to fail (and send us down a wild goose chase)__tracebackhide__per https://docs.pytest.org/en/6.2.x/example/simple.html#writing-well-integrated-assertion-helpers to allow failed test output to have less "noise"