[mypyc] Faster bytes formatting #10989
Merged
+219
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Aug 18, 2021
| # https://www.python.org/dev/peps/pep-0461/ | ||
| def test_bytes_formatting() -> None: | ||
| val = 10 | ||
| assert b"%x" % val == b'a' |
There was a problem hiding this comment.
Test producing an empty bytes object (e.g. b"%b" % bytes() and b"" % ()).
Add test for __bytes__ conversion (of create an issue if it doesn't work yet).
| @@ -64,3 +64,11 @@ | |||
| return_type=bytes_rprimitive, | |||
| c_function_name='CPyBytes_Join', | |||
| error_kind=ERR_MAGIC) | |||
|
|
|||
| bytes_build_op = custom_op( | |||
| """Merge the list of literals and the list of substitutions | ||
| alternatively using 'bytes_build_op'. | ||
|
|
||
| The literals should only contains ascii literal objects. |
There was a problem hiding this comment.
Do these need to be ascii? Is it sufficient for them to be arbitrary bytes literals?
|
|
||
| for a, b in zip(literals, substitutions): | ||
| if a: | ||
| result_list.append(builder.load_bytes(a.encode('ascii'))) |
There was a problem hiding this comment.
If you'd use latin1 as the encoding, could we support non-ascii bytes values?
There was a problem hiding this comment.
The literals inside BytesExpr is guaranteed to be ascii literals, otherwise it won't pass the type-checker.
|
I checked that this makes the |
JukkaL
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
convert_expr_to_bytesthat convert values to bytes.CPyBytes_Buildandjoin_formatted_bytes.Test Plan
Several run tests and an irbuild test for
CPyBytes_Build