FIx various typos #11498
Merged
FIx various typos #11498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via `codespell -q 3 -S ./mypyc/external/googletest -L alo,ans,asend,ba,bre,dne,fo,haa,ist,larg,myu,nams,spawnve,statics,thow,ure,wont`
|
Please review f7798ec closely |
| @@ -121,7 +121,7 @@ class type(object): | |||
| def __new__(cls, name: str, bases: Tuple[type, ...], namespace: Dict[str, Any]) -> type: ... | |||
| def __call__(self, *args: Any, **kwds: Any) -> Any: ... | |||
| def __subclasses__(self: _TT) -> List[_TT]: ... | |||
| # Note: the documentation doesnt specify what the return type is, the standard | |||
| # Note: the documentation doesn't specify what the return type is, the standard | |||
There was a problem hiding this comment.
Could you make these changes in the separate typeshed repo instead? Mypy just copies it in.
There was a problem hiding this comment.
Sure, what's the repo address?
There was a problem hiding this comment.
https://github.com/python/typeshed, thanks! Please remove the typeshed changes from this PR, we'll carry them in the next time we sync typeshed into this repo.
JelleZijlstra
approved these changes
Nov 9, 2021
luzpaz
added a commit
to luzpaz/typeshed
that referenced
this pull request
Nov 9, 2021
Found via `codespell -q 3 -L alo,asend,ba,nams,spawnve ` Originally found downstream python/mypy#11498 (comment)
luzpaz
added a commit
to luzpaz/typeshed
that referenced
this pull request
Nov 9, 2021
Found via `codespell -q 3 -L alo,asend,ba,nams,spawnve` Originally found downstream python/mypy#11498 (comment)
hauntsaninja
approved these changes
Nov 9, 2021
| # Include import froms that import names defined in __all__. | ||
| # Include import forms that import names defined in __all__. |
There was a problem hiding this comment.
I think the original version was correct here. This is referring to "import froms" as in from x import y statements, not import forms.
hauntsaninja
added a commit
that referenced
this pull request
Nov 10, 2021
As pointed out by @pranavrajpal in #11498 (comment)
hauntsaninja
added a commit
that referenced
this pull request
Nov 10, 2021
As pointed out by @pranavrajpal in #11498 (comment)
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Found via `codespell -q 3 -S ./mypyc/external/googletest -L alo,ans,asend,ba,bre,dne,fo,haa,ist,larg,myu,nams,spawnve,statics,thow,ure,wont`
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
As pointed out by @pranavrajpal in python#11498 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3 -S ./mypyc/external/googletest -L alo,ans,asend,ba,bre,dne,fo,haa,ist,larg,myu,nams,spawnve,statics,thow,ure,wont