Speed up ArgKind methods by changing them into top-level functions #11546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mypyc can't call enum methods as native methods. This seems to speed up compiled mypy by around 1%.
|
Related to #11547. |
msullivan
approved these changes
Nov 13, 2021
|
How hard would it be to fix this in mypyc? is there an issue for it already? |
|
The relevant issue is mypyc/mypyc#906. This may not be too difficult to fix. I can spend half an hour on a mypyc fix, and we can forget about this if it looks like it's not much trouble to fix it properly. |
|
Looks like we dropped this unfortunately, there's a bunch of merge conflicts now. |
JelleZijlstra
approved these changes
Jan 27, 2022
raghavthind2005
approved these changes
Mar 15, 2022
|
Three approving reviews (each on a different PR) in the space of a minute, @raghavthind2005? Impressive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypyc can't call enum methods as native methods. This seems to speed
up compiled mypy by around 1% (rough measurement).