Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash involving undefined cyclic import * #11681

Merged
merged 5 commits into from Dec 13, 2021

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #11064. Co-authored by @hi-ogawa

Pushes #11346 over the finish line. Implements the suggestion in #11346 (review)

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Crashes involving import cycles can be a pain to debug, so this is much appreciated.

@JukkaL JukkaL merged commit b640914 into python:master Dec 13, 2021
@hauntsaninja hauntsaninja deleted the placehold branch December 15, 2021 00:32
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
Fixes python#11064. Co-authored by @hi-ogawa 

Pushes python#11346 over the finish line. Implements the suggestion in 
python#11346 (review)

Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic analysis deferral crash
3 participants