Run self-check on Windows as part of CI #11909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in python#11895, mypy's test suite currently does not pass a mypy self-check when run on Windows. This should hopefully be fixed by python/typeshed#6812, but running a self-check on Windows as part of the CI tests should help avoid this issue in the future. This new CI test should hopefully fail until python#11905 is merged, confirming the diagnosis of the problem that I made in python#11895. Once python#11905 is merged, it should hopefully then pass, allowing this PR to be merged.
|
The new test is failing, as expected -- I'll leave this as a draft PR until #11905 is merged. |
|
I synced typeshed, but it looks like we still have a number of failures. Probably fixable with some |
|
Aaaand the Windows self-check is finally green 🥳🥳 |
Comment on lines
+520
to
+521
| if sys.platform == "win32": | ||
| assert False, "curses is not available on Windows" |
There was a problem hiding this comment.
Suggested change
| if sys.platform == "win32": | |
| assert False, "curses is not available on Windows" | |
| assert sys.platform != "win32", "curses is not available on Windows" |
This should work, right?
There was a problem hiding this comment.
I tried that first, doesn't seem to work unfortunately
There was a problem hiding this comment.
Ironically the only reason why curses is causing the self-check to fail is because of my own PR to typeshed python/typeshed#6749
JelleZijlstra
approved these changes
Jan 28, 2022
|
Thanks @JelleZijlstra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #11895, mypy's test suite currently does not pass a mypy self-check when the self-check is run on Windows. This should hopefully be fixed by python/typeshed#6812. However, running a self-check on Windows as part of the CI tests should help avoid this issue in the future, and shouldn't slow down the CI too much, since it's a very fast test.
This new CI test should hopefully fail until #11905 is merged, confirming the diagnosis of the problem that I made in #11895. Once #11905 is merged, it should hopefully then pass, allowing this PR to be merged.