Change final classes without __bool__ method to always be True #12187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolunThompson
changed the title
BolunThompson
changed the title
BolunThompson
changed the title
|
Diff from mypy_primer, showing the effect of this PR on open source code: rich (https://github.com/willmcgugan/rich)
+ rich/spinner.py:83: error: Statement is unreachable
black (https://github.com/psf/black)
+ src/blib2to3/pgen2/tokenize.py:603:29: error: Right operand of "or" is never evaluated
|
sobolevn
reviewed
Feb 16, 2022
| @@ -451,6 +459,13 @@ def test_false_only_of_union(self) -> None: | |||
| assert fo.items[0].can_be_false | |||
| assert fo.items[1] is tup_type | |||
|
|
|||
| def test_false_only_of_truthy_type_is_uninhabited(self) -> None: | |||
There was a problem hiding this comment.
I think that it will be more useful to add tests to some check-*.test file.
I think that these ones can be removed.
|
The Black change is also a false positive. It's checking a member of this dict: https://github.com/psf/black/blob/main/src/blib2to3/pgen2/tokenize.py#L159 But the members of that dict can be None, so it's legitimate to look at |
|
I'm too busy to work on this now, so anybody can finish this. If I remember correctly one of the errors related to my PR was not handling Union types correctly; I don't remember the cause of the other error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #12158
Changes it so that final classes without a
__bool__or__len__method are always True.Test Plan
Tests are added to test/testtypes.py