Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest typing.Callable when using callable as type #12204

Merged
merged 1 commit into from Feb 17, 2022
Merged

Suggest typing.Callable when using callable as type #12204

merged 1 commit into from Feb 17, 2022

Conversation

siiptuo
Copy link
Contributor

@siiptuo siiptuo commented Feb 17, 2022

Description

Follow-up PR based on this comment. Now for:

def c(d: callable): pass

mypy will suggest:

callable.py:1: error: Function "builtins.callable" is not valid as a type
callable.py:1: note: Perhaps you meant "typing.Callable" instead of "callable"?

Test Plan

Added a unit test to verify the new output.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit d02db50 into python:master Feb 17, 2022
@hauntsaninja
Copy link
Collaborator

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants