Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum regression #12258 #12260

Merged
merged 2 commits into from Feb 28, 2022
Merged

Fix enum regression #12258 #12260

merged 2 commits into from Feb 28, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 28, 2022 •
edited

Closes #12258
Closes #12262

@sobolevn
Copy link
Member Author

I will wait for the CI to pass (or not) and then add more tests to this feature.

@sobolevn
Copy link
Member Author

Will close #12262 as well.

@github-actions

This comment has been minimized.

Sign in to view
@sobolevn sobolevn marked this pull request as draft February 28, 2022 05:17
@sobolevn sobolevn marked this pull request as ready for review February 28, 2022 07:16
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JukkaL
JukkaL approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Code looks good. I can't say that I fully understand the subclassing rules, but the detailed test coverage gives me confidence to merge this.

@JukkaL JukkaL merged commit feab209 into python:master Feb 28, 2022
@AlexWaygood
Copy link
Member

Thanks for the rapid response @sobolevn!

@AlexWaygood AlexWaygood mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sobolevn @AlexWaygood @JukkaL