(🐞) Don't report when inferring expression types in an empty context #12729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
force-pushed
the
peek_ahead
branch
2 times, most recently
from
7bc3db4
to
2c49887
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
May 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
peek_ahead
branch
from
896a00d
to
cae7d6f
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
peek_ahead
branch
from
cae7d6f
to
81132b5
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
peek_ahead
branch
from
81132b5
to
99f836d
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
KotlinIsland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On overloads, don't report reveals and
Anyexprs when inferring func args from an empty context.Test Plan
I added a test. 😄
resolves #11953
resolves #12727
resolves #5879