Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.980 backport] Update pos-only unit tests for Python 3.10.7 (#13660) #13665

merged 1 commit into from
Sep 14, 2022


Copy link

@cdce8p cdce8p commented Sep 14, 2022

Backport #13660 to fix test issues with Python 3.10.7.


The CI has started to sporadically fail depending on whether 3.10.6 is
picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example:


On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects
using PEP 570 syntax unless `--python-version` is set to 3.8 or higher
(this is due to python/cpython#95935). However,
this makes several unit tests fail.

This PR updates those unit tests so that the CI passes on both 3.10.6
and 3.10.7
Copy link

Hah, you beat me to it. This was on my to-do list for today -- thanks!

Copy link

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@hauntsaninja hauntsaninja merged commit 2b2953a into python:release-0.980 Sep 14, 2022
@cdce8p cdce8p deleted the backport-pos-only branch September 14, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants