Replace x[:] with x.copy()
#14949
Merged
Replace x[:] with x.copy()
#14949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the [`FURB145`](https://github.com/dosisod/refurb/blob/master/docs/checks.md#furb145-no-slice-copy) error code. In my (limited) testing using `.copy()` is faster then both interpreted and compiled versions of `[:]` (see python#14887 (comment)). See python#14887
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn
approved these changes
Mar 25, 2023
leotada
approved these changes
Apr 14, 2023
ethanhs
approved these changes
Apr 24, 2023
|
I will go ahead and merge this ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
FURB145error code from Refurb. In my (limited) testing, usingx.copy()is faster then both the interpreted and compiled versions ofx[:](see #14887 (comment)).See #14887 for more info.