Clarify usage of callables regarding type object in docs #15079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Apr 19, 2023
docs/source/protocols.rst
Outdated
| @@ -319,7 +319,8 @@ member: | |||
| batch_proc([], bad_cb) # Error! Argument 2 has incompatible type because of | |||
| # different name and kind in the callback | |||
|
|
|||
| Callback protocols and :py:data:`~typing.Callable` types can be used interchangeably. | |||
| Callback protocols and :py:data:`~typing.Callable` types can be used interchangeably (altough using | |||
| :py:data:`~typing.Type` on a :py:data:`~typing.Callable` might lead to unexpected results). | |||
There was a problem hiding this comment.
Without going into details, this is the reason I've added this part: https://mypy-play.net/?mypy=1.2.0&python=3.11&gist=25c2697cb3c308ae1609b0f6dc9ff0ff
hauntsaninja
reviewed
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15024. Phrasing might be incorrect, I'll take reviews if required