Clarify difference between disallow_untyped_defs and disallow_incomplete_defs #15247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beauxq
reviewed
May 15, 2023
docs/source/command_line.rst
Outdated
| @@ -353,12 +353,17 @@ definitions or calls. | |||
| .. option:: --disallow-untyped-defs | |||
|
|
|||
| This flag reports an error whenever it encounters a function definition | |||
| without type annotations. | |||
| with without type annotations or with incomplete type annotations. | |||
There was a problem hiding this comment.
It looks like this "with" doesn't belong.
|
@hauntsaninja can take a look? (seeing as you've closed #9964) |
hauntsaninja
approved these changes
May 18, 2023
|
Thanks for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9963, #12693.
Previously addressed in #9964.
disallow_untyped_defsis a superset ofdisallow_incomplete_defs, as seen here:The latter playground results in: