New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error location for class patterns #15506

Merged

JelleZijlstra merged 1 commit into master from issue-15496

Jun 23, 2023

Member

sobolevn commented Jun 23, 2023

Now it uses the same pattern for .fail as similar places:

mypy/mypy/checkpattern.py

Line 459 in 2d8ad8e

self.msg.fail(message_registry.CLASS_PATTERN_GENERIC_TYPE_ALIAS, o)
mypy/mypy/checkpattern.py

Line 493 in 2d8ad8e

self.msg.fail(message_registry.CLASS_PATTERN_TOO_MANY_POSITIONAL_ARGS, o)
etc

Test proves that this problem is now fixed.
Closes #15496


          Fix error location for class patterns

9deb0cf

sobolevn requested a review from hauntsaninja

June 23, 2023 13:37

Contributor

github-actions bot commented Jun 23, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

JelleZijlstra merged commit c099b20 into master

20 checks passed

JelleZijlstra deleted the issue-15496 branch

June 23, 2023 14:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment