Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __match_args__ to dataclasses with no fields #15749

Merged
merged 2 commits into from Jul 22, 2023
Merged

Add __match_args__ to dataclasses with no fields #15749

merged 2 commits into from Jul 22, 2023

Conversation

hamdanal
Copy link
Contributor

It exists at runtime.

Fixes #15748

AlexWaygood
AlexWaygood approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamdanal hamdanal mentioned this pull request Jul 22, 2023
Closed
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@AlexWaygood AlexWaygood added topic-match-statement Python 3.10's match statement topic-dataclasses labels Jul 22, 2023
hauntsaninja
hauntsaninja approved these changes Jul 22, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit d2022a0 into python:master Jul 22, 2023
18 checks passed
@hamdanal hamdanal deleted the dataclass-matchargs branch July 23, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
topic-dataclasses topic-match-statement Python 3.10's match statement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__match_args__ is not added to dataclasses with no fields
3 participants
@hamdanal @hauntsaninja @AlexWaygood