New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attrs, dataclasses: don't enforce slots when base doesn't #15976

Merged

sobolevn merged 1 commit into python:master from ikonst:fix-dataclass-slots-from-non-slots

Aug 28, 2023

Contributor

ikonst commented Aug 28, 2023 •

edited

Doing the same thing we do for regular classes.

Fixes #15975


          attrs, dataclasses: don't enforce slots when base doesn't

cc003b2

Contributor

github-actions bot commented Aug 28, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

sobolevn approved these changes

View reviewed changes

sobolevn merged commit 010da0b into python:master

18 checks passed

ikonst deleted the fix-dataclass-slots-from-non-slots branch

August 28, 2023 11:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment