New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mypyc] Make tuple packing and unpacking more efficient #16022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One or two typos I spotted:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
I'm not sure what's going on with the build failures. The tests seem to pass locally, but in CI the mypyc-compiled builds get a sigterm, apparently. |
jhance
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously returning a tuple from a function resulted in redundant increfs and decrefs
for each item, and similarly unpacking the returned tuple in an assignment had extra
incref/decref pair per item. This PR introduces these changes to make this better:
Unborrow
op.KeepAlive
op can steal the operands to avoid decrefing the operands.Assignment from tuple now uses the three final features to avoid increfs and decrefs
when unpacking a tuple in assignment. The docstrings in this PR contain additional
explanation of how this works.
In a micro-benchmark this improved performance by about 2-5%. In realistic examples
the impact is likely small, but every little helps.
Here is an example where this helps: