Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__qualname__ and __module__ are available in class bodies #16215

Merged
merged 2 commits into from Oct 4, 2023
Merged

__qualname__ and __module__ are available in class bodies #16215

merged 2 commits into from Oct 4, 2023

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Oct 2, 2023

Resolves #10570
Resolves #6473

@asottile
Copy link
Contributor Author

asottile commented Oct 2, 2023

tbh idk what I'm doing -- I assume there's a better place to add these

@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

(It's possible we should be putting these into the symbol tables or something, but given that type in typeshed has these attrs, I can't think of a way it would make a difference)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit b1ba661 into python:master Oct 4, 2023
18 checks passed
@asottile asottile deleted the qualname-module-class-body branch October 4, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asottile @hauntsaninja