Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when expanding invalid Unpack in a Callable alias #17028

Merged
merged 1 commit into from Apr 8, 2024
Merged

Fix crash when expanding invalid Unpack in a Callable alias #17028

merged 1 commit into from Apr 8, 2024

Conversation

hamdanal
Copy link
Contributor

Fixes #16937

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing!

@hauntsaninja hauntsaninja merged commit e2fc1f2 into python:master Apr 8, 2024
18 checks passed
@hamdanal hamdanal deleted the crash-16937 branch April 15, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when unpacking non TypeVarTuple in args list to Callable alias
2 participants
@hamdanal @hauntsaninja