Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for comparisons like None in list/set/tuple #17154

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add check for comparisons like None in list/set/tuple #17154

wants to merge 12 commits into from

Commits on Apr 23, 2024

  1. Add check for None in list/set/tuple and refine the types of the va… 

    …riables to not include None
    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    61ff8a5 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    af0ae37 View commit details
    Browse the repository at this point in the history

  3. change the any(is_literal_none(i) for i in right.items) to be check… 

    …ed at the end of the if condition (preventing exceptions if right has no attribute "items")
    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f7905a0 View commit details
    Browse the repository at this point in the history

  4. renaming and slight formatting

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d5348c4 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/detect-None-in-default-iterables… 

    …' into detect-None-in-default-iterables
    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a7bd447 View commit details
    Browse the repository at this point in the history

  6. Add tests for the new feature

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c09f73a View commit details
    Browse the repository at this point in the history

  7. Remove the small test file that I used

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dbc86d2 View commit details
    Browse the repository at this point in the history

  8. Return the comment to where it originally was (not relevant for my ne… 

    …w feature)
    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    285e883 View commit details
    Browse the repository at this point in the history

  9. Add check for None in the iterable

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9fb1a91 View commit details
    Browse the repository at this point in the history

  10. Change checks to be with sets, lists, and tuples

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    846cb0d View commit details
    Browse the repository at this point in the history

  11. Minor fixes for mypy

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    75107f2 View commit details
    Browse the repository at this point in the history

  12. Minor fixes of messages

    @eladshoshani
    eladshoshani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7c9afad View commit details
    Browse the repository at this point in the history