stubgen: Gracefully handle invalid Optional and recognize aliases to PEP 604 unions
#17386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Hmm not sure about this. I lean towards saying we should refuse the temptation to guess if we're given an invalid annotation. I would probably print an error to the terminal noting that we encountered an invalid annotation on line X, fall back to using |
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Jun 15, 2024
AlexWaygood
approved these changes
Jun 15, 2024
hamdanal
changed the title
Optional usage in stubgenOptional and recognize aliases to PEP 604 unions
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes 2 issues with invalid
Optional(inspired by an error reported in #17197):OptionalOptionalwith more than one index as an unknown type instead of choosing the first type.It also fixes PEP 604 unions not being recognized as type aliases.