New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing node in --quick mode also for type aliases #3356

Merged
merged 1 commit into from May 12, 2017

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented May 12, 2017

This should fix #3355

For deserialized node with cross_ref, if we can't find the cross_ref in quick mode, then we need to put something in there, see #3304. This PR does exactly the same for the case of a type alias node.

@gvanrossum Could yo please check that this works?

@ilevkivskyi ilevkivskyi changed the title from Fix missing TypeInfo in --quick mode also for type aliases to Fix missing node in --quick mode also for type aliases May 12, 2017

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum May 12, 2017

Member

As soon as I have a repro...

Member

gvanrossum commented May 12, 2017

As soon as I have a repro...

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum May 12, 2017

Member

I still haven't managed to repro the original issue (though several users are reporting it is happening to them). Rather than spending more time to try and repro it locally and reliably so I can test whether this fixes them, I am probably just going merge this and watch the crash logs next week...

Member

gvanrossum commented May 12, 2017

I still haven't managed to repro the original issue (though several users are reporting it is happening to them). Rather than spending more time to try and repro it locally and reliably so I can test whether this fixes them, I am probably just going merge this and watch the crash logs next week...

@gvanrossum gvanrossum merged commit aeeacd7 into python:master May 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment