Fix missing node in --quick mode also for type aliases #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
changed the title
|
As soon as I have a repro... |
|
I still haven't managed to repro the original issue (though several users are reporting it is happening to them). Rather than spending more time to try and repro it locally and reliably so I can test whether this fixes them, I am probably just going merge this and watch the crash logs next week... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3355
For deserialized node with
cross_ref, if we can't find thecross_refin quick mode, then we need to put something in there, see #3304. This PR does exactly the same for the case of a type alias node.@gvanrossum Could yo please check that this works?