Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to the fine-grained incremental mode #4438

Merged
merged 16 commits into from
Jan 10, 2018
Merged

Various fixes to the fine-grained incremental mode #4438

merged 16 commits into from
Jan 10, 2018

Commits on Jan 8, 2018

  1. Fixes to refreshing class definitions 

    Bundling these in a single commit since a single test case reproduces
both of these issues and initially it wasn't clear if they are a single
issue.

1. Fix AST merge of ClassDefs.
2. If there is a previous error in a class body, refresh module top
   level instead of the whole class.
3. Generally fix the previous target handling in case of nested
   definitions (full test coverage missing).
    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    1e70e83 View commit details
    Browse the repository at this point in the history

  2. Fix stripping of type alias in class body

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    ef1c0a6 View commit details
    Browse the repository at this point in the history

  3. Bind class type variables when refreshing a method

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    4188b77 View commit details
    Browse the repository at this point in the history

  4. Fix stripping of super expressions 

    Not sure if this will make a difference anywhere, but this seems
like the right thing to do.
    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    2468803 View commit details
    Browse the repository at this point in the history

  5. Reset subtype caches when stripping the AST

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    8ba0d9c View commit details
    Browse the repository at this point in the history

  6. Update TODO comment

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    aede69a View commit details
    Browse the repository at this point in the history

  7. Merge type variable definitions 

    TODO: Add test case
    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    56604ac View commit details
    Browse the repository at this point in the history

  8. Fix refresh of a named tuple subclass

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    767848a View commit details
    Browse the repository at this point in the history

  9. Fix refresh of NewType expressions

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    e7a672c View commit details
    Browse the repository at this point in the history

  10. Fixes to stale TypeInfos escaping from AST merge 

    I didn't add tests since it's unclear if these actually caused any
visible issues.
    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    ab98298 View commit details
    Browse the repository at this point in the history

  11. Fix up additional references in AST merge 

    Not sure if these changes fix user-visible issues, but this at least
makes things cleaner.
    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    788e41a View commit details
    Browse the repository at this point in the history

  12. Fix up another TypeInfo reference in AST merge 

    Not sure if this fixes an user-visible issue, but at least this
makes things more consistent.
    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    43b5f7d View commit details
    Browse the repository at this point in the history

  13. Fix AST diff of functional enums

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    ea9ebe9 View commit details
    Browse the repository at this point in the history

  14. Fix refresh of function Enum definition

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    10d17a9 View commit details
    Browse the repository at this point in the history

  15. Fix Enum test case

    @JukkaL
    JukkaL committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    3aca388 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. Merge branch 'master' into fine-grained-batch-3

    @JukkaL
    JukkaL committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    4ef22e4 View commit details
    Browse the repository at this point in the history