Fix dmypy run when no target given #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gvanrossum
reviewed
Jan 7, 2019
This won't be a problem, I look forward to taking advantage of some 3.5 features in several places :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dmypy runwithout a target given will cause the daemon to die unexpectedly on callingmypy.main.process_optionswith improper arguments.This catches the
SystemExitthe argument parser throws and capturessys.stderrfor the output of the parser. I had to backport redirect_stderr since that is not available in 3.4, but the backport can be removed in a couple of months when we drop support for 3.4.I'm not entirely sure if passing the way I'm passing the error messages is a good idea or not, but it certainly is better than dying with just
[WinError 233] No process is on the other end of the pipe.