Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed overlapped I/O when more data needs to be read #6272

Merged
merged 3 commits into from Jan 31, 2019
Merged

Fixed overlapped I/O when more data needs to be read #6272

merged 3 commits into from Jan 31, 2019

Commits on Jan 30, 2019

  1. Fix overlapped I/O when more data needs to be read 

    For some reason the tests didn't capture this, but ReadFile, not
GetOverlappedResult returns _winapi.ERROR_MORE_DATA, which means that we
would not do another read. This handles that and correctly peeks then
reads the remaining data.
    @ethanhs
    ethanhs committed Jan 30, 2019
    Copy the full SHA
    390537b View commit details
    Browse the repository at this point in the history

  2. Better error handling of failed writes

    @ethanhs
    ethanhs committed Jan 30, 2019
    Copy the full SHA
    e6f10b2 View commit details
    Browse the repository at this point in the history

  3. Simplify handling ERROR_MORE_DATA

    @ethanhs
    ethanhs committed Jan 30, 2019
    Copy the full SHA
    c3fb323 View commit details
    Browse the repository at this point in the history