Fix missing builtin aliases on Python 2 (and other versions) #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some builtin aliases (like
typing.ChainMap) are not available on some Python versions, or in some fixtures. However, if while they were first looked up while target namespace was incomplete, we put aPlaceholderNodeintyping. This PR either doesn't put or removes this placeholder node if we didn't find the target after the target namespace is complete.I didn't find a way to test this (since we don't have incremental
pythonevaltests), but I double-checked this fixes the crash with actual Python 2 stubs.