New analyzer: resolve name clashes between generated and existing nodes #6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2019
JukkaL
approved these changes
Jun 12, 2019
| @@ -290,6 +290,22 @@ def unmangle(name: str) -> str: | |||
| return name.rstrip("'") | |||
|
|
|||
|
|
|||
| def get_unique_redefinition_name(name: str, existing: Container[str]) -> str: | |||
There was a problem hiding this comment.
I wonder if the mangled names can be shown in error messages (say, when showing error context). If you believe that it might be the case, can you create a follow-up issue about it?
There was a problem hiding this comment.
Out of top of my head I found only one case (multiple inheritance) where we use names from symbol table instead of .name() or .fullname(), but there may be other. I will open an issue.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
…es (python#6972) Fixes python#6454. Fixes python#6973. Note that the solution doesn't guarantee the order of numbers N in foo-redefinitionN coincides with the textual order of nodes. But it looks like we don't need this for anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6454
Fixes #6973
Note that the solution doesn't guarantee the order of numbers
Ninfoo-redefinitionNcoincides with the textual order of nodes. But it looks like we don't need this for anything.