Fix new semantic analyser crash on unpacking to star lvalue and enable sample tests #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Jul 2, 2019
hauntsaninja
pushed a commit
that referenced
this pull request
Feb 8, 2023
Fixes #14250 This one is interesting. It looks like most likely this was caused by my PR #7127 that fixed other crash. After looking a bit more, `StarType` is something old, and should never by used. At least I didn't find `visit_star_type()` in any of the type visitors. Actually mypy already uses `assert False`, if we get to a non-special-cased star expression. Btw, I noticed that `pythoneval` test with empty expected output passes in case of a crash (at least on my machine), so I fix this too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7117
As explained in the issue this didn't crash with old analyser because it was compensated by another bug:
Var.is_readywas set toTruein some conditions thus silently inferring anAnytype instead of deferring the node, see added test.The actual crash was caused by the fact that star lvalue was previously checked as a generic reference expression, instead of processing it as name definition, thus triggering a bogus unexpected deferral.